RPL-Lite: don't reset DIO timer if the current interval is equal to Imin #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yatch
force-pushed
the
pr/reset-dio-timer
branch
from
8ac61ff
to
9cb2516
Compare
|
@simonduq Any objections to merging this? I'm not familiar with the RPL lite code, but this PR appears to fix a real problem, cites RFC 6206 for backing, includes new tests, and the new changes seem to make sense. Overall very well done. |
simonduq
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, heavy traffic of DIS prevents routers from sending DIOs. This issue is found only in
rpl-lite.Fixes #910