Skip to content

Conversation

RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Oct 14, 2025

Description

loadPackageFromHub wasn't passing api key, couldn't load private packages


Summary by cubic

Fix hub package loading to include auth headers so private packages can be downloaded. Unauthenticated requests now send empty headers.

  • Bug Fixes
    • loadPackageFromHub adds Authorization: Bearer when accessToken is present.
    • Applies to rule ZIP downloads and MCP config requests.
    • Tests updated to mock auth, verify header behavior, and handle HTTP errors.

@RomneyDa RomneyDa requested a review from a team as a code owner October 14, 2025 05:29
@RomneyDa RomneyDa requested review from sestinj and removed request for a team October 14, 2025 05:29
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 14, 2025
Copy link

github-actions bot commented Oct 14, 2025

✅ Review Complete

Code Review Summary

⚠️ Continue configuration error. Please verify that the assistant exists in Continue Hub.


Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Oct 14, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 14, 2025
@sestinj sestinj merged commit 64c7dd1 into main Oct 14, 2025
56 of 58 checks passed
@sestinj sestinj deleted the dallin/auth-for-package-loading branch October 14, 2025 06:04
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Oct 14, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2025
@sestinj
Copy link
Contributor

sestinj commented Oct 14, 2025

🎉 This PR is included in version 1.28.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants