Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CNI to 0.6.0 in install #314

Merged
merged 3 commits into from
Dec 21, 2017
Merged

Upgrade CNI to 0.6.0 in install #314

merged 3 commits into from
Dec 21, 2017

Conversation

vhosakot
Copy link
Member

@vhosakot vhosakot commented Dec 11, 2017

This PR upgrades CNI to 0.6.0 in install/k8s/configs/contiv.yaml.

Signed-off-by: Vikram Hosakote vhosakot@cisco.com

@vhosakot
Copy link
Member Author

build PR

@@ -15,7 +15,7 @@ data:
# The CNI network configuration to install on each node.
cni_config: |-
{
"cniVersion": "0.1.0",
"cniVersion": "0.6.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is a 1.4 manifest being upgraded to cni 0.6.0? I would expect only k8s 1.9 and greater to use 0.6.0.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment @danehans. Sure, I'll correct it. Btw, we are planning to deprecate k8s 1.4 in contiv/install. k8s 1.4 has already been deprecated in contiv/netplugin.

Copy link
Member Author

@vhosakot vhosakot Dec 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danehans I've reverted the CNI version for k8s 1.4 in the latest commit. I'll deprecate/remove k8s 1.4 in contiv/install in a separate PR.

@vhosakot
Copy link
Member Author

build PR

1 similar comment
@vhosakot
Copy link
Member Author

build PR

@@ -18,7 +18,7 @@ EOF

setenforce 0

yum install -y docker kubelet-1.6.5 kubeadm-1.6.5 kubectl-1.6.5 kubernetes-cni-1.6.5 ntp
yum install -y docker kubelet-1.6.5 kubeadm-1.6.5 kubectl-1.6.5 kubernetes-cni ntp

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to explicitly pick a version any more? Seems like we'd want to limit this.

@@ -20,7 +20,7 @@ setenforce 0

swapoff -a

yum install -y docker kubelet-1.8.4 kubeadm-1.8.4 kubectl-1.8.4 kubernetes-cni-1.8.4 ntp
yum install -y docker kubelet-1.8.4 kubeadm-1.8.4 kubectl-1.8.4 kubernetes-cni ntp

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here

@@ -23,7 +23,7 @@ yum install -y docker ebtables \
https://fedorapeople.org/groups/kolla/kubeadm-1.6.0-0.alpha.0.2074.a092d8e0f95f52.x86_64.rpm \
https://fedorapeople.org/groups/kolla/kubectl-1.5.4-0.x86_64.rpm \
https://fedorapeople.org/groups/kolla/kubelet-1.5.4-0.x86_64.rpm \
https://fedorapeople.org/groups/kolla/kubernetes-cni-0.3.0.1-0.07a8a2.x86_64.rpm
kubernetes-cni

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k8s 1.4 will go away soonish, don't need to use updated CNI here

@dseevr
Copy link
Contributor

dseevr commented Dec 13, 2017

This needs a rebase now that @amccormi's changes have been merged

Vikram Hosakote added 3 commits December 19, 2017 18:30
Signed-off-by: Vikram Hosakote <vhosakot@cisco.com>
Signed-off-by: Vikram Hosakote <vhosakot@cisco.com>
Signed-off-by: Vikram Hosakote <vhosakot@cisco.com>
@vhosakot
Copy link
Member Author

vhosakot commented Dec 19, 2017

@dseevr @amccormi Rebased, tested and pushed latest commit.

@vhosakot
Copy link
Member Author

build PR

@vhosakot
Copy link
Member Author

build PR

@vhosakot
Copy link
Member Author

Green gate ready for merge.

@chrisplo chrisplo merged commit baded77 into contiv:master Dec 21, 2017
@vhosakot vhosakot deleted the install_cni_upgrade branch December 21, 2017 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants