-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade CNI to 0.6.0 in install #314
Conversation
build PR |
install/k8s/k8s1.4/contiv.yaml
Outdated
@@ -15,7 +15,7 @@ data: | |||
# The CNI network configuration to install on each node. | |||
cni_config: |- | |||
{ | |||
"cniVersion": "0.1.0", | |||
"cniVersion": "0.6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is a 1.4 manifest being upgraded to cni 0.6.0? I would expect only k8s 1.9 and greater to use 0.6.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comment @danehans. Sure, I'll correct it. Btw, we are planning to deprecate k8s 1.4
in contiv/install
. k8s 1.4
has already been deprecated in contiv/netplugin
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danehans I've reverted the CNI version for k8s 1.4 in the latest commit. I'll deprecate/remove k8s 1.4 in contiv/install
in a separate PR.
build PR |
1 similar comment
build PR |
cluster/k8s1.6/bootstrap_centos.sh
Outdated
@@ -18,7 +18,7 @@ EOF | |||
|
|||
setenforce 0 | |||
|
|||
yum install -y docker kubelet-1.6.5 kubeadm-1.6.5 kubectl-1.6.5 kubernetes-cni-1.6.5 ntp | |||
yum install -y docker kubelet-1.6.5 kubeadm-1.6.5 kubectl-1.6.5 kubernetes-cni ntp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to explicitly pick a version any more? Seems like we'd want to limit this.
cluster/k8s1.8/bootstrap_centos.sh
Outdated
@@ -20,7 +20,7 @@ setenforce 0 | |||
|
|||
swapoff -a | |||
|
|||
yum install -y docker kubelet-1.8.4 kubeadm-1.8.4 kubectl-1.8.4 kubernetes-cni-1.8.4 ntp | |||
yum install -y docker kubelet-1.8.4 kubeadm-1.8.4 kubectl-1.8.4 kubernetes-cni ntp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment here
cluster/k8s1.4/bootstrap_centos.sh
Outdated
@@ -23,7 +23,7 @@ yum install -y docker ebtables \ | |||
https://fedorapeople.org/groups/kolla/kubeadm-1.6.0-0.alpha.0.2074.a092d8e0f95f52.x86_64.rpm \ | |||
https://fedorapeople.org/groups/kolla/kubectl-1.5.4-0.x86_64.rpm \ | |||
https://fedorapeople.org/groups/kolla/kubelet-1.5.4-0.x86_64.rpm \ | |||
https://fedorapeople.org/groups/kolla/kubernetes-cni-0.3.0.1-0.07a8a2.x86_64.rpm | |||
kubernetes-cni |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
k8s 1.4 will go away soonish, don't need to use updated CNI here
This needs a rebase now that @amccormi's changes have been merged |
Signed-off-by: Vikram Hosakote <vhosakot@cisco.com>
Signed-off-by: Vikram Hosakote <vhosakot@cisco.com>
Signed-off-by: Vikram Hosakote <vhosakot@cisco.com>
build PR |
build PR |
Green gate ready for merge. |
This PR upgrades CNI to
0.6.0
ininstall/k8s/configs/contiv.yaml
.Signed-off-by: Vikram Hosakote vhosakot@cisco.com