infranw: cleanup pending remote endpoints gracefully on network delete #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e cleaned up endpoints
| @@ -569,7 +569,18 @@ func (self *OfnetAgent) RemoveNetwork(vlanId uint16, vni uint32, Gw string, Vrf | |||
| // make sure there are no endpoints still installed in this vlan | |||
| for _, endpoint := range self.endpointDb { | |||
There was a problem hiding this comment.
I think this block needs to be moved to the beginning of this function. i.e. clean up the endpoints before performing any other delete action.
|
LGTM |
|
LGTM and thanks for adding the tests :) |
GraysonWu
pushed a commit
to GraysonWu/ofnet
that referenced
this pull request
Aug 19, 2022
1. Maintain a variable for Switch connection, and close the previous one when reconnecting to Switch. This can ensure only one unix socket is used between Controller and Switch. 2. Add timeout when sending message to Switch or waiting for message from Switch, to avoid Controller entering blocking state in a long time. 3. Remove a duplicated SwitchFeatures request, and send SwitchConfig and Controller setting message when switch is connected. 4. Resolve OpenFlow version misconfiguration bugs in Hello message, and PortModification message. Signed-off-by: wenyingd <wenyingd@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
infra nw automatically creates endpoints on every node. When infra nw is deleted, netplugin has sufficient knowledge to cleanup only local endpoints. Remote endpoints synced via ofnet will still be pending in ofnet database, since not all nodes have received and processed infra nw delete to cleanup their endpoints. In this case, cleanup the remote endpoints gracefully in ofnet instead of crash.