Fix Command modifier for input mappings on on MacOS #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be MacOS specific. The problem is, that Qt does not generate QKeyEvent::text() on key press for Command modifiers with characters (such as C or V), but indeed does on key release events (neither press nor repeat).
christianparpart
force-pushed
the
fix/macos-command-modifier-bindings
branch
from
a006a98
to
c29a123
Compare
…Super) This is purely for convenience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be MacOS specific. The problem is, that Qt does not generate QKeyEvent::text() on key press for Command modifiers with characters (such as C or V), but indeed does on key release events (neither press nor repeat).
We however do not want to trigger input mappings on release but on press (for now).
Closes #1379.