Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend hyperlink decoration documentation #1439

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

saliaku
Copy link
Contributor

@saliaku saliaku commented Jan 29, 2024

Description

closes #1437

Describe your changes in detail

Your issue description (body) goes here

Motivation and Context

Why is this change required? What problem does it solve?

How Has This Been Tested?

  • Please describe how you tested your changes.
  • see how your change affects other areas of the code, etc.

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • I have read the CONTRIBUTING document in my spoken language, and understand the terms
  • I have updated (or added) the documentation accordingly.
  • I have added tests to cover my changes.
  • I have gone through all the steps, and have thoroughly read the instructions

@github-actions github-actions bot added documentation Improvements or additions to documentation frontend Contour Terminal Emulator (GUI frontend) labels Jan 30, 2024
@saliaku
Copy link
Contributor Author

saliaku commented Jan 30, 2024

is there anything more that needs to be done ?

@uspasojevic96 uspasojevic96 changed the title Issue #1437 Extend hyperlink decoration documentation Jan 30, 2024
@uspasojevic96 uspasojevic96 added the no changelog Tells the CI to not require a changelog entry label Jan 30, 2024
@saliaku
Copy link
Contributor Author

saliaku commented Jan 30, 2024

why are some checks getting failed , what can I do to make it work ?

@uspasojevic96
Copy link
Member

You can address the editorconfig checks, when you click on Details of that check you will see what needs to be changed, everything else is fine

@saliaku
Copy link
Contributor Author

saliaku commented Jan 30, 2024

i have made changes to the .gitignore file

@christianparpart
Copy link
Member

why are some checks getting failed , what can I do to make it work ?

They're not running because only src/ has not been touched. We maybe should tweak that outside of that PR at some point.

@christianparpart christianparpart merged commit b610c52 into contour-terminal:master Jan 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation frontend Contour Terminal Emulator (GUI frontend) no changelog Tells the CI to not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve documentation on hyperlink decorations
3 participants