Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add response helpers for Node.js for reducing boilerplate in projects #47

Merged
merged 7 commits into from
Sep 13, 2021

Conversation

n1ru4l
Copy link
Contributor

@n1ru4l n1ru4l commented Sep 2, 2021

As discussed the goal here is to reduce boilerplate for tutorials.

The code is super specific for Node.js HTTP environments and obviously, those will not work for Lambda Functions, etc.

@dotansimha dotansimha self-requested a review September 2, 2021 08:09
Copy link
Contributor

@dotansimha dotansimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a few minor things/questions.

Also, Do we need to update the README as well?

packages/core/lib/send-result/node.ts Outdated Show resolved Hide resolved
packages/core/lib/send-result/node.ts Outdated Show resolved Hide resolved
packages/core/lib/send-result/node.ts Outdated Show resolved Hide resolved
packages/core/lib/send-result/node.ts Outdated Show resolved Hide resolved
packages/core/lib/send-result/node.ts Outdated Show resolved Hide resolved
packages/core/lib/send-result/node.ts Outdated Show resolved Hide resolved
packages/core/lib/send-result/node.ts Outdated Show resolved Hide resolved
packages/core/lib/send-result/node.ts Outdated Show resolved Hide resolved
packages/core/lib/send-result/node.ts Outdated Show resolved Hide resolved
@dotansimha
Copy link
Contributor

The code is super specific for Node.js HTTP environments and obviously, those will not work for Lambda Functions, etc.

I guess it's fine, mainly because most implementation with Lambda are not going to use long-living request sessions.

@dotansimha dotansimha merged commit 185b64c into contra:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants