Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #58, this adds support for bound sockets being UNIX domain sockets. This is something that I needed for an application on our end and think might be generally useful. This works by extending the regex in argument parsing to accept filenames that don't have colons in them as UNIX domain sockets. The
state.bind
stuff is then modified to be inet or unix bind objects which abstracts out the logic of how to create/bind each type of socket properly. If binding the socket results inEADDRINUSE
, we'll do the connect, stat, unlink dance to try and clean up old dead sockets. The address family is added to the child environment for each socket so that workers can know which family to bind with more easily.Issues/questions:
I can't get the tests to run locally without errors with or without this patch, so I'm not clear on their status. Will check with Travis once that runs.It looks like the tests are failing to install packages etc. on various versions, but where they install everything is checking out.