Revert unneeded changes from "Fixes for nested multipliers (#59)" #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are still failing. :( |
|
Yes, the primary reason is that webchemistry/testing-helpers is broken with latest Nette. If you merge #96, that will fix it, and only two test failures will remain:
This pull request does not fix any tests, only cleans the code a bit. But spending most of the last weekend trying to decipher the changes in #59, I am now convinced the PR should be reverted wholesale, and the fix reimplemented. I will try looking into it and into fixing #83 this weekend. |
|
Thanks. The best thing would be drop |
|
Do you have some replacement in mind? Otherwise, the simplest solution
would probably be copying the used subset of it into the multiple tree and
fixing it locally.
…On Fri, 23 Feb 2024, 17:32 Milan Felix Šulc, ***@***.***> wrote:
Thanks. The best thing would be drop webchemistry/testing-helpers at all.
:-/
—
Reply to this email directly, view it on GitHub
<#92 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFMEYYO6ONP32IYB4OKR7TYVDACNAVCNFSM6AAAAABDNXPRP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRRGYZTQMBQHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This partially reverts commit 39725d3, only keeping the part relevant for nested support and a PHPUnit deprecation fix. The commit introduced a regression in `testGroupManualRenderWithButtons` so this will minimize the changes that could affect it. - Latte 2 macros are trivial to migrate and unclearly named, no need to keep them for BC. - The onSuccess handlers were already fixed in ed96ba0. - `testGroupManualRenderWithButtons` look like remnants of debugging effort, they do not fix the test. For reference, the reverted change is the following commit that was squashed into 39725d3, except for the change to `testSendNested`: 2c33de2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts commit 39725d3, only keeping the part relevant for nested support and a PHPUnit deprecation fix.
The commit introduced a regression in
testGroupManualRenderWithButtonsso this will minimize the changes that could affect it.testGroupManualRenderWithButtonslook like remnants of debugging effort, they do not fix the test.For reference, the reverted change is the following commit that was squashed into 39725d3, except for the change to
testSendNested: 2c33de2