Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "coverage" #1506

Closed
wants to merge 1 commit into from
Closed

Revert "coverage" #1506

wants to merge 1 commit into from

Conversation

bqpd
Copy link
Contributor

@bqpd bqpd commented Jul 15, 2020

Reverts #1505

testing if this last PR was causing the test_table_diff failures

@bqpd
Copy link
Contributor Author

bqpd commented Jul 15, 2020

test models please

@bqpd
Copy link
Contributor Author

bqpd commented Jul 15, 2020

@1ozturkbe from the above it looks like those table_diff errors are caused by the recent commit, but I still can't reproduce it on this end!

@bqpd
Copy link
Contributor Author

bqpd commented Jul 17, 2020

test models please

@bqpd bqpd closed this Jul 17, 2020
@bqpd bqpd deleted the revert-1505-coverage branch July 17, 2020 19:40
@1ozturkbe
Copy link
Contributor

Glad this was resolved! Thanks though @bqpd for checking if this was breaking robust!

@bqpd
Copy link
Contributor Author

bqpd commented Jul 17, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants