Skip to content

Commit 1024743

Browse files
committed
fix(fetch): do not fetch from feeds that lack a url
1 parent aff5588 commit 1024743

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

src/main/java/com/conveyal/datatools/manager/jobs/FetchProjectFeedsJob.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,15 @@ public void jobLogic() {
4040
if (!FeedSource.FeedRetrievalMethod.FETCHED_AUTOMATICALLY.equals(feedSource.retrievalMethod)) {
4141
continue;
4242
}
43+
// warn if a feed is setup to be fetched automatically, but doesn't have a url defined
44+
if (feedSource.url == null) {
45+
LOG.warn(
46+
"Feed '{}' ({}) is set to be fetched automatically, but lacks a url!",
47+
feedSource.name,
48+
feedSource.id
49+
);
50+
continue;
51+
}
4352
// No need to track overall status on this FetchProjectFeedsJob. All "child" jobs execute in threadpool,
4453
// so we don't know their status.
4554
FetchSingleFeedJob fetchSingleFeedJob = new FetchSingleFeedJob(feedSource, owner, true);

0 commit comments

Comments
 (0)