Release #278
Merged
Release #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a security vulnerability in this project where the `pom.xml` files were configuring Maven to resolve dependencies over HTTP instead of HTTPS. Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
…_dependencies [SECURITY] Use HTTPS to resolve dependencies in Maven Build
Some modifications regarding passing additional FeedValidator classes are included. BREAKING CHANGE: Change in the type of optional arguments for GTFS.validate and Feed.validate
…th callback approach.
…h Java's BiFunction equivalent.
… method overrides.
…gtfs-lib into field-length-validator
MTC Field length validation
Comment on lines
32
to
33
| import java.util.List; | ||
| import java.util.function.BiFunction; |
There was a problem hiding this comment.
Remove these tow unused imports.
binh-dam-ibigroup
approved these changes
Apr 13, 2020
|
I don't know what the deal is with the unresolved dependencies from the build. |
The Conveyal maven repo appears to no longer exist, so the GeoJSON Jackson module is no longer available.
On April 11, 2020, the geotools repo changed locations to repo.osgeo.org (see https://web.archive.org/web/20200413163145/https://www.osgeo.org/foundation-news/new-osgeo-repo/).
Remove Conveyal geojson module to fix Travis build/dep issue
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
============================================
+ Coverage 64.99% 65.27% +0.28%
- Complexity 866 879 +13
============================================
Files 134 135 +1
Lines 6725 6742 +17
Branches 789 794 +5
============================================
+ Hits 4371 4401 +30
+ Misses 2055 2040 -15
- Partials 299 301 +2
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
Contains #279, #276, and #273.