Disable nesting checks for jsx-a11y/label-has-for #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
landonreed
approved these changes
Oct 29, 2019
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
=======================================
Coverage 63.78% 63.78%
=======================================
Files 19 19
Lines 497 497
Branches 96 96
=======================================
Hits 317 317
Misses 156 156
Partials 24 24Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 5.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important note: This PR is for merging directly to master!
Why is this a PR directly to master? Because #295 upgraded a whole bunch of eslint packages to new major versions which introduced thousands of (in my opinion good) linting errors that will eventually make our code more standardized. When we eventually merge
devto master to create the next master release we should bump it up to another major version to reflect this change.As asked in ibi-group/datatools-ui#508, I went ahead and updated the code to pass all the jsx/a11y tests. However, a certain case of the
label-has-associated-controlrule requires manually changing your jsx/a11y to recognize custom components. Therefore, I went ahead and just disabled the nesting part of that rule.