Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relevant walk-to-transit trips lost due to limit parameter #163

Closed
demory opened this issue Jan 14, 2015 · 2 comments
Closed

Relevant walk-to-transit trips lost due to limit parameter #163

demory opened this issue Jan 14, 2015 · 2 comments

Comments

@demory
Copy link
Contributor

demory commented Jan 14, 2015

In the following example, bike-to-transit trips crowd out a quality one-seat walk-to-transit trip (the ART 41; disable biking to show) due to the default limit of 3. In such cases the profile router should return at least one valid walk-to-transit trip.

http://www.carfreeatoz.com/planner?from=5000%20Columbia%20Pike%2C%20Arlington%2C%20Virginia%2C%20USA&to=2020%2014th%20St%20N%2C%20Arlington%2C%20Virginia%2C%20USA&modes=BICYCLE%2CBUS%2CTRAINISH%2CWALK%2CCAR&start_time=7&end_time=9&days=M%E2%80%94F

@trevorgerhardt
Copy link
Member

@abyrd this issue creeps up in a few different places and I think it's a high priority to tackle. When you get a chance I was wondering if you could comment on the timeline or let me know if we need to figure out more details of the implementation.

abyrd added a commit to opentripplanner/OpenTripPlanner that referenced this issue Jan 21, 2015
@abyrd
Copy link
Member

abyrd commented Jan 23, 2015

This has been resolved in OTP. The limit parameter now applies to each access mode separately.

@abyrd abyrd closed this as completed Jan 23, 2015
abyrd added a commit to conveyal/r5 that referenced this issue Oct 27, 2015
Former-commit-id: de5bad862f707427b3ed327db54700f02c37e458
abyrd added a commit to conveyal/r5 that referenced this issue Oct 27, 2015
Former-commit-id: de5bad862f707427b3ed327db54700f02c37e458
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants