Zoom: add to opportunity dataset model #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retrieve it from the WebMercatorExtents that are passed in on creation.
This requires zoom levels to be specified when creating opportunity datasets.
trevorgerhardt
force-pushed
the
add-zoom-to-dataset-model
branch
from
dfb0c66
to
8aec154
Compare
ansoncfit
approved these changes
May 25, 2022
There was a problem hiding this comment.
This requires a database migration (adding zoom), which we are handling separately.
I tested the new features running this branch and the corresponding UI locally to create a zoom 11 grid. The grid creation worked as expected, and the resulting file was usable after uploading it to production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add zoom field to opportunity datasets. Required for https://github.com/conveyal/ui/pull/1801