Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dual accessibility CSV headers and column order #912

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Conversation

abyrd
Copy link
Member

@abyrd abyrd commented Nov 22, 2023

No description provided.

Copy link
Member

@ansoncfit ansoncfit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. As we discussed on the call, results look sensible.

@abyrd
Copy link
Member Author

abyrd commented Nov 22, 2023

Noting here that the final commit is a workaround for a weird detail of Java: strangely it's possible to read the value of an uninitialized final variable in a constructor and this is not considered an error. This would often fail fast for null references but not for primitives - their final values are not actually final. Java also disallows setting such final fields before calling the superclass constructor. We may be able to reorder some initialization to lessen this effect but for now we're just leaving the dual threshold out of the column headers.

@abyrd abyrd merged commit 6363b28 into dev Nov 22, 2023
3 checks passed
@abyrd abyrd deleted the dual-access-tweaks branch November 22, 2023 05:28
@abyrd
Copy link
Member Author

abyrd commented Nov 23, 2023

I just discovered that the problem described above is the subject of a change introduced in Java 22:
https://openjdk.org/jeps/447 "statements before super()"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants