Properly update display internals when updating bounds #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
=========================================
- Coverage 0.18% 0.18% -0.01%
=========================================
Files 37 37
Lines 3181 3182 +1
Branches 660 660
=========================================
Hits 6 6
- Misses 2612 2613 +1
Partials 563 563
Continue to review full report at Codecov.
|
landonreed
reviewed
May 21, 2020
| @@ -178,6 +178,7 @@ export default class Transitive { | |||
| if (!this.display) return | |||
| const smWestSouth = sm.forward(llBounds[0]) | |||
| const smEastNorth = sm.forward(llBounds[1]) | |||
| this.display.reset() | |||
There was a problem hiding this comment.
Probably worth adding a comment here related to this issue. Otherwise, incredible work finding the needle in the haystack!
landonreed
approved these changes
May 21, 2020
|
Steps to reproduce/verify:
|
|
🎉 This PR is included in version 0.13.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some internals in the display class weren't properly getting updated when the map bounds were being changed. This was causing crazy-looking paths being drawn in certain cases.
Fixes opentripplanner/otp-react-redux#159