Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vpc-cidr parameter to convox install for custom vpc sizes #191

Merged
merged 1 commit into from
Dec 1, 2015

Conversation

cleblanc87
Copy link
Contributor

This PR adds the ability to specify the size of the VPC you want to allocate for a convox rack. The subnets are calculated dynamically by splitting the chosen vpc into the 4 largest subnets that will fit.

@csquared
Copy link
Contributor

csquared commented Dec 1, 2015

@csquared
Copy link
Contributor

csquared commented Dec 1, 2015

@cleblanc87 this looks great! i'm going to cut a branch release that either of us can install to test. in the meantime i have two requests:

  1. make a quick gofmt pass to get all the spaces uniform
  2. make the subnet calculation its own function that we can write a test for. (thinking something simple in cmd/convox/install_test.go

happy to assist in any way with the above

@csquared
Copy link
Contributor

csquared commented Dec 1, 2015

just did a convox install --version 20151201171730-cleblanc87-custom-cidr ...

screen shot 2015-12-01 at 9 32 45 am

screen shot 2015-12-01 at 9 31 03 am

Looks good!

@cleblanc87
Copy link
Contributor Author

Removed subnet calculation in favor of cli parameters, for simplicities sake

@csquared
Copy link
Contributor

csquared commented Dec 1, 2015

@cleblanc87 if you don't mind pulling master and rebasing i'd love to merge this in!

csquared added a commit that referenced this pull request Dec 1, 2015
Add vpc-cidr parameter to convox install for custom vpc sizes
@csquared csquared merged commit 7ccc20a into convox:master Dec 1, 2015
@csquared
Copy link
Contributor

csquared commented Dec 1, 2015

thanks @cleblanc87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants