Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document building locally #30

Merged
merged 3 commits into from
Sep 18, 2015
Merged

document building locally #30

merged 3 commits into from
Sep 18, 2015

Conversation

csquared
Copy link
Contributor

No description provided.

@ddollar
Copy link
Contributor

ddollar commented Sep 17, 2015

Can you put the install --development instructions in that section as well? Can move the whole section above convox start and call it Prerequisites

@csquared
Copy link
Contributor Author

will do

@csquared
Copy link
Contributor Author

i kinda want to make it possbile to do convox install —development > .env or have some other way of getting the ENV data to the .env file without cut and paste. closing the terminal before copying has bit me more than once.

some ideas:

  • have install print to STDERR by default and write vars to STDOUT
  • have install detect stdout is a pipe ?
  • take it as a flag —env-file .env and still print with other stuff

ddollar
ddollar reviewed Sep 17, 2015
View reviewed changes
api/README.md

And the `PASSWORD` is in the ENV data in your `.env` file.

### Building locally
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This header is confusing to me. Building a Rack? Maybe just add this to Prereqs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be a little overwhelming to put it in Prequisites. What about changing it to convox build?

@ddollar
Copy link
Contributor

ddollar commented Sep 17, 2015

👍

ddollar added a commit that referenced this pull request Sep 18, 2015
@ddollar
Merge pull request #30 from convox/doc-local-builds
ae25f73 
document building locally
@ddollar ddollar merged commit ae25f73 into master Sep 18, 2015
@ddollar ddollar deleted the doc-local-builds branch September 18, 2015 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csquared @ddollar