Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Papertrail Service #75

Merged
merged 15 commits into from
Oct 9, 2015
Merged

Papertrail Service #75

merged 15 commits into from
Oct 9, 2015

Conversation

nzoschke
Copy link
Contributor

@nzoschke nzoschke commented Oct 7, 2015

This depends on convox/papertrail#1 and the s3://convox/lambda/papertrail.zip artifact that it releases.

Todo

  • Implement CF rate limit workaround. Cache URL on filesystem [https://github.com/convox/papertrail/commit/0158423ff7eeefa52ae3fd688c6ee7bf8355abbf]
  • Factor papertrail specific code into it's own file?
  • Refactor Arns from Parameter to Outputs
  • Restrict Lambda IAM scope
  • Review and document service link/unlink API
  • Update api/manifest.yml
  • Fix log prefixes that show up in Papertrail
  • Send errors to rollbar
  • Documentation [https://github.com/convox/papertrail/blob/master/Readme.md]

@nzoschke nzoschke changed the title Papertrail Papertrail Service Oct 7, 2015
@nzoschke
Copy link
Contributor Author

nzoschke commented Oct 8, 2015

@ddollar any feedback on the API?

router.HandleFunc("/services/{service}/link", api("service.link", ServiceLink)).Methods("POST")
router.HandleFunc("/services/{service}/link/{app}", api("service.unlink", ServiceUnlink)).Methods("DELETE")

@ddollar
Copy link
Contributor

ddollar commented Oct 8, 2015

Consider putting the app name in the URL for the POST as well.

@ddollar
Copy link
Contributor

ddollar commented Oct 8, 2015

Also please make sure to update api/manifest.yml to add the new routes.

@nzoschke
Papertrail service template
df7f356 
Parameters for Papertrail URL and linked Kinesis ARNs
Resources for Lambda function and IAM role
Templated resources for Lambda event source mapping for every linked Kinesis ARNs
@nzoschke
service link and unlink cli and client
d5e58f1
@nzoschke
Service link and unlink routes, controllers and model logic
c74b2ad
@nzoschke
extract Papertrail functions to own file
8ec7c5d
@nzoschke
implement DashName which reverses UpperName, e.g. my-app -> MyApp -> …
e759c8c 
…my-app
@nzoschke
move ARNs from Parameter to Outputs
03d9bc7
@nzoschke
move links from service into new controller
db498cb
@nzoschke
document links API
444ed07
@nzoschke
move client link functions to own file and rename; use in cli
56e6570
@nzoschke
tighter IAM policy
79c3122
@nzoschke
even tighter IAM around CF describe stacks
db44f2b
@nzoschke
Link controller methods use httperr
ec5c0bc
@nzoschke
remove debug statements
52c1f63
@csquared
Copy link
Contributor

csquared commented Oct 9, 2015

👍

@nzoschke
Copy link
Contributor Author

nzoschke commented Oct 9, 2015

Punting on the winston syslog prefix for now

nzoschke pushed a commit that referenced this pull request Oct 9, 2015
Merge pull request #75 from convox/papertrail
ac7fc2e 
Papertrail Service
@nzoschke nzoschke merged commit ac7fc2e into master Oct 9, 2015
@nzoschke nzoschke deleted the papertrail branch October 9, 2015 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nzoschke @ddollar @csquared