Write tests cleanup #167
Merged
Write tests cleanup #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevir
approved these changes
Oct 12, 2017
| @@ -20,7 +20,7 @@ describe(`operations.write`, () => { | |||
| } | |||
| }`); | |||
|
|
|||
| describe(`invalid write on a root, expect an object`, () => { | |||
| describe(`invalid nested values, expect an object`, () => { | |||
There was a problem hiding this comment.
"expect an object" is still a verb phrase - maybe "scalar in place of object value"?
| @@ -23,7 +23,7 @@ describe(`operations.write`, () => { | |||
| } | |||
| }`); | |||
|
|
|||
| describe(`write to inner nodes`, () => { | |||
| describe(`updates inner nodes`, () => { | |||
added 10 commits
October 12, 2017 14:16
…licate references" and rename files
yuit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #136. This PR is best reviewed by commit as each commit is equal to an update of the folder.
What happen in this PR are:
simplifying
describeclause. We only have two layers of describe clauses - one for specifying the tested operation such as write, read etc. the other is a test scenario itself.rename file to have better name
Some guidelines I try to stick with:
describedescription is to describe scenario, majority are just type of payload or query.without verb to describe an act, we assume tests are just doing write operation.
If tests do more than just write, use verb to specify such action in the
describedescription such as "updates" etc.anything that is an entity in the system is referred as
referencesasentitywill be represent as reference off a root queryanything that is non-entity is referred as
valuesAll setup should be in
beforeAllclause;itclause should just do the test