Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added badges to readme + Identicon preview #35

Merged
merged 2 commits into from
May 22, 2024
Merged

Added badges to readme + Identicon preview #35

merged 2 commits into from
May 22, 2024

Conversation

LucaCappelletti94
Copy link
Contributor

Hi, great library!

I wanted to see a preview of its results, so I thought it best to add it to the README for other users.

While I was at it, I also added the badges for the docs and crate.

Luca

@conways-glider
Copy link
Owner

I love these suggestions!

I think I might change one of the example inputs just so that we show off a wider color palette. I'll take a look at a few different inputs and might suggest changes based on that.

@LucaCappelletti94
Copy link
Contributor Author

Maybe instead of fully randomizing colors, a nice option may be to pick at random from a pantone color list like matplotlib?

I can add the hexas fairly quickly.

@conways-glider
Copy link
Owner

I've been toying with the idea of allowing users to optionally select their own colors. Adding palettes and theming to this project is a great idea!

I think I'll follow up with that in another MR and then post images of the palettes/themes added, along with documentation on how to make your own.

Copy link
Owner

@conways-glider conways-glider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging Approving. I'll follow up with an MR soon to add themes, along with custom themes, while preserving a random pastel option (the current behavior) as default.

I'll merge as soon as checks pass.

@conways-glider conways-glider merged commit d90714e into conways-glider:main May 22, 2024
6 checks passed
@conways-glider
Copy link
Owner

@LucaCappelletti94
I've filed an issue for theme/palette design - #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants