Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write test that creates/checks a matrix of all y/n option combinations #591

Closed
audreyfeldroy opened this issue Jun 5, 2016 · 4 comments
Closed

Write test that creates/checks a matrix of all y/n option combinations #591

audreyfeldroy opened this issue Jun 5, 2016 · 4 comments
Labels
help wanted

Comments

@audreyfeldroy
Copy link
Member

Ensure that the project generates without errors for every possible combination of:

  • y/n values entered
  • choices entered when selecting from a list, e.g. test all license choices

(Similarly filed in Cookiecutter PyPackage: audreyfeldroy/cookiecutter-pypackage#184)
@jeffshek
Copy link

jeffshek commented Jun 8, 2016

@audreyr i'll give this a shot, i'll start with the cc-django one and port it over if it's what we're going for

@jeffshek
Copy link

Sorry, it has been stupid busy, but I have this bookmarked and every few days I remind myself of the guilt that I didn't do this yet! I'm going to take a look into this week to give it a shot (if not already done)

@webyneter
Copy link
Collaborator

@jeffshek, any news on that?

@kenlavoie
Copy link

kenlavoie commented Jan 10, 2019 •
edited
Loading

@browniebroke / @audreyr - is this still an open issue?

@browniebroke browniebroke mentioned this issue Mar 11, 2019
Merged
This was referenced Mar 21, 2019
Open
Merged
browniebroke added a commit that referenced this issue Apr 1, 2019
@browniebroke
Test all possible template combinations (#1993)
4e70a4b 
## Description

Fixes #591.

## Rationale

We are currently not testing many combinations, we run Flake8 on the generated project with default options, but that rarely catch any issues.

## Use case(s) / visualization(s)

Catch problems with invalid combinations, for instance, it fails due to Whitenoise breaking flake8 with `django-compressor` because `STATIC_URL` was undefined here:

https://github.com/pydanny/cookiecutter-django/blob/b91c70d75578e56c2ca74400684c5b5523cd0cd4/%7B%7Bcookiecutter.project_slug%7D%7D/config/settings/production.py#L185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@audreyfeldroy @jeffshek @browniebroke @webyneter @kenlavoie