Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a deprecation warning in Rails 5 #50

Merged
merged 2 commits into from
Mar 24, 2017
Merged

Fix a deprecation warning in Rails 5 #50

merged 2 commits into from
Mar 24, 2017

Conversation

sachin21
Copy link
Contributor

@sachin21 sachin21 commented Mar 6, 2017 •
edited
Loading

If using chanko is rails 5, use prepend_before_action. else use the prepend_before_filter.

@sachin21 sachin21 force-pushed the fix_deprecation_in_rails5 branch 2 times, most recently from 043b0df to 3bfed84 Compare March 8, 2017 13:08
@sachin21
Copy link
Contributor Author

@eagletmt @r7kamura How about this?

@sachin21 sachin21 changed the title Fix deprecation warning in Rails 5 Fix a deprecation warning in Rails 5 Mar 22, 2017
@sachin21 sachin21 force-pushed the fix_deprecation_in_rails5 branch 2 times, most recently from de5650f to 18e3a35 Compare March 22, 2017 16:25
@eagletmt
Copy link
Member

Looks good.
How about dropping support for Rails 3.x and always use prepend_before_action ? prepend_before_action is available in Rails >= 4.0, IIRC.

/cc @cookpad/dev-infra

@moro
Copy link

moro commented Mar 22, 2017

Looks good for me, too.

And I also agree with @eagletmt suggestion; dropping Rails 3.x support.

@r7kamura
Copy link
Contributor

LGTM, and +1 for the supported Rails version change 👍

@sachin21 sachin21 force-pushed the fix_deprecation_in_rails5 branch 3 times, most recently from d02c902 to 770af60 Compare March 23, 2017 12:16
@sachin21
Copy link
Contributor Author

sachin21 commented Mar 23, 2017 •
edited
Loading

Thank you for your review. I changed to following.

Changes

  • Replace prepend_before_filter with prepend_before_action.
  • Drop support Rails 3.x and update README.md.

@eagletmt @r7kamura @moro

@r7kamura
Copy link
Contributor

r7kamura commented Mar 23, 2017 •
edited
Loading

@sachin21 Great 👍

We also need to change the runtime dependency version on chanko.gemspec:

chanko/chanko.gemspec

Line 20 in 97bed65

gem.add_dependency "rails", ">= 3.0.10"

@sachin21
Copy link
Contributor Author

Oops! I'll fix right now.

@sachin21
Copy link
Contributor Author

sachin21 commented Mar 23, 2017 •
edited
Loading

@r7kamura Thank you! fixed 😄

@eagletmt eagletmt merged commit 52cca3b into cookpad:master Mar 24, 2017
@sachin21 sachin21 deleted the fix_deprecation_in_rails5 branch March 24, 2017 22:54
@sachin21
Copy link
Contributor Author

sachin21 commented Mar 24, 2017 •
edited
Loading

Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eagletmt eagletmt eagletmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sachin21 @eagletmt @moro @r7kamura