Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update depedency name #30

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Update depedency name #30

merged 1 commit into from
Dec 4, 2018

Conversation

sogamoso
Copy link
Contributor

@sogamoso sogamoso commented Dec 3, 2018

Closes #29

Recently trollop got renamed to optimist. This renames the
dependency and gets rid of the deprecation warning we are currently
getting:

Fetching: trollop-2.9.9.gem (100%)
!    The 'trollop' gem has been deprecated and has been replaced by 'optimist'.
!    See: https://rubygems.org/gems/optimist
!    And: https://github.com/ManageIQ/optimist

Recently `trollop` got renamed to `optimist`. This renames the
dependency and gets rid of the deprecation warning we are currently
getting:

```rb
Fetching: trollop-2.9.9.gem (100%)
!    The 'trollop' gem has been deprecated and has been replaced by 'optimist'.
!    See: https://rubygems.org/gems/optimist
!    And: https://github.com/ManageIQ/optimist
```
@sogamoso sogamoso requested review from Knack and balvig December 3, 2018 12:06
Copy link
Contributor

@balvig balvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Thank you 👍

@balvig
Copy link
Contributor

balvig commented Dec 4, 2018

Also just realized we should get rid of those now deprecated git extensions...

@sogamoso sogamoso merged commit a92d32d into master Dec 4, 2018
@sogamoso sogamoso deleted the switch-to-optimist branch December 4, 2018 11:34
@Knack
Copy link
Member

Knack commented Dec 4, 2018

Thank you, @sebasoga!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants