ALB Ingress Controller #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I copied this from the terratest documentation https://terratest.gruntwork.io/docs/getting-started/quick-start/ In all the examples they do this... https://github.com/gruntwork-io/terratest/search?q=http-helper&unscoped_q=http-helper they also follow the same pattern when importing I am not sure if it is idiomatic, as I think the real go idiom is to not have dashes in package names https://blog.golang.org/package-names, I this case I am happy to just stay consistent to what they are doing in the tereatest examples, since we don't get to change there package naming! |
mtpereira
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for provisioning the ALB ingress controller.
For now the default is to not provision this component, based on the discussions in #87 as some cluster admins might prefer to use another implementation.
It can be enabled by setting
aws_alb_ingress_controller = trueon the Cluster module.Fixes #87