Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added types for single-type players #1098

Closed
wants to merge 0 commits into from
Closed

Added types for single-type players #1098

wants to merge 0 commits into from

Conversation

JuanM04
Copy link
Contributor

@JuanM04 JuanM04 commented Dec 4, 2020

This PR solves #953

What I did:

  • Created a folder named types with all the typings.
  • Added cp types/*.d.ts . to npm run prepublishOnly, so the types will be detected.
  • Added utilities to types/_utils.d.ts.
  • Added linting with npm run lint:ts

types/_utils.d.ts Outdated Show resolved Hide resolved
types/_utils.d.ts Outdated Show resolved Hide resolved
types/dailymotion.d.ts Outdated Show resolved Hide resolved
types/_utils.d.ts Outdated Show resolved Hide resolved
types/index.d.ts Outdated Show resolved Hide resolved
types/streamable.d.ts Outdated Show resolved Hide resolved
@afzaalahmad
Copy link
Contributor

@JuanM04 please make sure to use proper commit messages. It would be awesome to use git interactive rebasing and merge these all commits into one commit with proper message added player typings.

Regards

@JuanM04
Copy link
Contributor Author

JuanM04 commented Dec 8, 2020

@afzaalahmad merging all the commits into one would be awesome. If there is something I can do to help, please tell me

@cookpete
Copy link
Owner

cookpete commented Dec 8, 2020

It would be awesome to use git interactive rebasing and merge these all commits into one com

There's no need as I'm using squash and merge in this repo, so the commits will be squashed into one merge commit anyway.

@isometriq
Copy link

types for custom players would be awesome too

@cookpete
Copy link
Owner

Amazing work 💪

I managed to break everything when trying to rebase on master and force push (accidentally force pushed my master rather than my rebased branch of your master) so I'll merge this manually.

cookpete pushed a commit that referenced this pull request Jan 20, 2021
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this pull request May 20, 2021
webmiraclepro added a commit to webmiraclepro/video-player that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants