-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added types for single-type players #1098
Conversation
@JuanM04 please make sure to use proper commit messages. It would be awesome to use Regards |
@afzaalahmad merging all the commits into one would be awesome. If there is something I can do to help, please tell me |
There's no need as I'm using squash and merge in this repo, so the commits will be squashed into one merge commit anyway. |
types for custom players would be awesome too |
Amazing work 💪 I managed to break everything when trying to rebase on |
Manual merge of cookpete/react-player#1098 Fixes cookpete/react-player#953
Manual merge of cookpete/react-player#1098 Fixes cookpete/react-player#953
This PR solves #953
What I did:
types
with all the typings.cp types/*.d.ts .
tonpm run prepublishOnly
, so the types will be detected.types/_utils.d.ts
.npm run lint:ts