fix: ensure lazy typedefs mirror defaults

[jahed]

Fixes #1146

Notes

To avoid the cyclic dependency (which would cause an invalid lazy -> base -> lib dependency), since base.d.ts is used internal only, it's safe to move the default types there (to avoid base -> lib) and re-export them in index.d.ts.

I also moved index.d.ts to lib/index.d.ts as that's where lib/index.js is. So main and typings match to avoid confusion. This also solves the relative path issue when copying it for lazy/index.d.ts.

[JuanM04]

I also moved index.d.ts to lib/index.d.ts as that's where lib/index.js is. So main and typings match to avoid confusion. This also solves the relative path issue when copying it for lazy/index.d.ts.

That's pretty neat

To avoid the cyclic dependency (which would cause an invalid lazy -> base -> lib dependency), since base.d.ts is used internal only, it's safe to move the default types there (to avoid base -> lib) and re-export them in index.d.ts.

You just changed where the cyclic dependency happens: now, for example,soundcloud.d.ts imports base.d.ts and vice-versa.
Maybe, you should create a types/lazy/index.d.ts like this:

export * from '../index'
export { default } from '../index'

[jahed]

You just changed where the cyclic dependency happens

Ah, of course. 🤦🏽 I'll avoid resolving the cyclic dependency. Thought it was causing errors so went for a quick "fix" but it was actually npm link anyway. (microsoft/TypeScript#6496 (comment))

I've pushed an update.

[cookpete]

Great work @jahed. Thanks for the help @JuanM04 👍