Fix Vimeo instantiation error catching #240
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors happening during instantiation of the Vimeo player (for example: a private video or 404) were not caught and passed to the error handler. This resulted in a bunch of console errors (triggered by the
this.player.on(...)
calls after instantiation), a broken player, and no way to do anything about it or even tell the user what is going on.This change calls
player.ready()
right after instantiation (which returns a promise), allowing us to check if everything is OK (in which case we attach all the listeners), or not (in which case we pass the error on to ouronError
method).More info: vimeo/player.js#165