Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilePlayer calls onBuffer when "waiting" is fired #613

Closed
wants to merge 1 commit into from

Conversation

me-andre
Copy link
Contributor

@me-andre me-andre commented Apr 3, 2019

Introduces support of onBuffer callback to the FilePlayer

@cookpete
Copy link
Owner

cookpete commented Apr 4, 2019

This has already been discussed before: #74. The waiting event seems too buggy to rely on for onBuffer, especially if onPlay is then not called when playing is resumed.

There is a getInternalPlayer() instance method if you want to set this in your own implementation.

@me-andre
Copy link
Contributor Author

me-andre commented Apr 4, 2019

I definitely agree.
Not firing onPlay after "waiting" can badly break things, as it did to my app.
This is what is fixed by #612

@me-andre
Copy link
Contributor Author

Closing in favor of #615

@me-andre me-andre closed this Apr 10, 2019
@NahidAhmed07
Copy link

how to change buffer spinner color. Its default color is white.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants