Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash when called on a non-existing file #1

Closed
cooljeanius opened this issue Jan 21, 2018 · 4 comments
Closed

fix crash when called on a non-existing file #1

cooljeanius opened this issue Jan 21, 2018 · 4 comments
Labels

Comments

@cooljeanius
Copy link
Owner

cooljeanius commented Jan 21, 2018

I forget what the actual crash was that originally made me add this to the TODO, but apparently it happened?

@cooljeanius
Copy link
Owner Author

@kencu appears to have rediscovered this in macports/macports-ports#21227 perhaps? I think I might just need to check to ensure that argv is nonnull before using it?

cooljeanius added a commit that referenced this issue Jun 15, 2024
this ought to address issue #1
@cooljeanius
Copy link
Owner Author

OK this ought to be fixed by 4ede21a; @kencu can you confirm?

@kencu
Copy link

kencu commented Jun 15, 2024

yes, that works nicely

@cooljeanius
Copy link
Owner Author

yes, that works nicely

OK thanks, I'll bump the version and then push a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants