Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move default services to collect stats on to a match statement #35

Merged
merged 2 commits into from
May 10, 2023

Conversation

cooperlees
Copy link
Owner

  • Had issues unwrapping_or to a HashMap compiling in some environments
  • We only need an empty vector, so lets use a match statement to do so if the config has no [services] section
  • Add in fix to not log service_stats as a missed field in flatten_units

Test:

  • Remove [services] from monitord.conf and test running
    • cargo run -c monitord.conf -vv

- Had issues unwrapping_or to a HashMap compiling in some environments
- We only need an empty vector, so lets use a match statement to do so
  if the config has no `[services]` section
- Add in fix to not log service_stats as a missed field in flatten_units

Test:

- Remove `[services]` from monitord.conf and test running
  - `cargo run -c monitord.conf -vv`
@cooperlees cooperlees added the bug Something isn't working label May 10, 2023
@cooperlees cooperlees merged commit 6ef23ff into main May 10, 2023
@cooperlees cooperlees deleted the service_match branch May 10, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant