Api consistency between acquire and release #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an optional callback function for release, notifying if release is called multiple times for the same connection.
|
This looks good and should be merged. |
|
One small thing, could you add the update jsdoc stuff for |
|
Actually, I've just hacked about with this and thought about it a bit more and a callback feels wrong here because release behaviour is synchronous, so we could just return something like a boolean to indicate if the object was really released, true for was releases, false for not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the API between
acquireandreleasea bit more consistent (both accepting callbacks), adding an optional callback for release, notifying the callback if it has been called multiple times for the same connection.