fix Pass object additional feilds #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass.Coupon, Pass.EventTicket, Pass.EventTicket, and Pass.Generic don't have any additional feilds availabe so we don't need to provide methods for additional feilds. boardingPass was being overwritten by the additonal feild method, now fixed. resolves coorasse#29
coorasse
reviewed
May 16, 2024
Co-authored-by: Alessandro Rodi <coorasse@gmail.com>
|
If you look at the documentation for Pass.Coupon Pass.EventTicket Pass.Generic Pass.BoardingPass is the only pass type that allows for an additional property. |
annaswims
commented
May 16, 2024
| pass[:groupingIdentifier] = @pass.grouping_identifier if @pass.grouping_identifier | ||
| pass[:nfc] = @pass.nfc if @pass.nfc | ||
| pass[:relevantDate] = @pass.relevant_date if @pass.relevant_date | ||
| pass[:semantics] = @pass.semantics if @pass.semantics | ||
| pass[:store_card] = @pass.store_card if @pass.store_card | ||
| pass[:userInfo] = @pass.user_info if @pass.user_info | ||
|
|
||
| pass[@pass.pass_type] = { |
There was a problem hiding this comment.
We can be confident that this does not cause any new problems, because
pass[:coupon], pass[:eventTicket], and pass[:generic] were being overwritten by pass[@pass.pass_type] here.
pass[:store_card] should've been pass[:storeCard], so it never did anything useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass.Coupon, Pass.EventTicket, Pass.EventTicket, and Pass.Generic don't have any additional feilds availabe so we don't need to provide methods for additional fields.
https://developer.apple.com/documentation/walletpasses/pass
boardingPass was being overwritten by the additional field method, now fixed.
resolves #29