Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(test): test in Node 20 #85

Merged
merged 2 commits into from
Sep 16, 2024
Merged

ci(test): test in Node 20 #85

merged 2 commits into from
Sep 16, 2024

Conversation

gr2m
Copy link
Collaborator

@gr2m gr2m commented Sep 13, 2024

thanks to #78, we can now test in Node 20

thanks to #78, we can now test in Node 20
@gr2m gr2m enabled auto-merge (squash) September 13, 2024 20:08
Copy link
Collaborator

@francisfuzz francisfuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍕 @gr2m Yay!

Non-blocking question (that could be a suggestion, depending on answer): in tandem with this change, should we also update our Contributing Guide's Development's Prerequisites section to include version 20 as a valid version for running the project? 💭

@gr2m gr2m merged commit 520f8a0 into main Sep 16, 2024
5 checks passed
@gr2m gr2m deleted the gr2m-patch-1 branch September 16, 2024 21:50
@francisfuzz
Copy link
Collaborator

@gr2m 😂 Merged within the same minute as my approval -- wanted to flag that just in case it's of interest!

Copy link

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants