URL-escape links to handle "weird" filenames #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rickenharp can you give an example? I'd like to have a test case if possible. |
|
Sure, if you have a file called "Example #1.txt", currently will generate a link to http://0.0.0.0:4331/Example%20#1.txt, which won't work because the unescaped hash is interpreted as a fragment identifier, resulting in the wrong link to '/Example%20' instead. |
|
@rickenharp heel 3.1.3 released, please make sure this version fixes the problem for you. |
|
Works great, thanks. 👍 |
|
Perfect! thanks for the bug report |
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Mar 15, 2014
## Version 3.1.3 - 2013-11-26 * URL encode the links to files [#14](copiousfreetime/heel#14) * Fix pid file cleanup on ruby 2.0 [#15](copiousfreetime/heel#15) ## Version 3.1.2 - 2013-10-16 * Fix usage of Mime::Types [#12](copiousfreetime/heel#12) [#13](copiousfreetime/heel#13) ## Version 3.1.1 - 2013-09-29 * Fix request logging [#10](copiousfreetime/heel#10)
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Mar 17, 2014
## Version 3.1.3 - 2013-11-26 * URL encode the links to files [#14](copiousfreetime/heel#14) * Fix pid file cleanup on ruby 2.0 [#15](copiousfreetime/heel#15) ## Version 3.1.2 - 2013-10-16 * Fix usage of Mime::Types [#12](copiousfreetime/heel#12) [#13](copiousfreetime/heel#13) ## Version 3.1.1 - 2013-09-29 * Fix request logging [#10](copiousfreetime/heel#10)
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Oct 11, 2014
## Version 3.1.3 - 2013-11-26 * URL encode the links to files [#14](copiousfreetime/heel#14) * Fix pid file cleanup on ruby 2.0 [#15](copiousfreetime/heel#15) ## Version 3.1.2 - 2013-10-16 * Fix usage of Mime::Types [#12](copiousfreetime/heel#12) [#13](copiousfreetime/heel#13) ## Version 3.1.1 - 2013-09-29 * Fix request logging [#10](copiousfreetime/heel#10)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some trouble with files containing the #-character. URL-escaping the link should avoid problems with unusual file names.