-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the GTK completion widget in CoqIDE #11400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there some parts of the code particularly to double-check? Trusting otherwise.
@eponier and @Alizter already commented on the bug report about the usability of this patch. Remaining issues that I don't know how to solve:
These behaviours are hardwired in GtkSourceView, and we have no control over them AFAICT. |
The point about the border is really a minor one. |
18edccf
to
17df0e7
Compare
I consider this ready. It could even be eligible for 8.11.0, but I am afraid this is lacking a larger test base. |
After testing, IMO this looks pretty good. Even if we need to tweak some stuff, the PR cannot be worse than the current status so I'm going to merge. |
Reviewed-by: ejgallego Reviewed-by: herbelin
In the end, I think I am going to backport this in 8.11.0. I'll test it a bit more before, but the answers from our aforementioned guinea pigs and my limited poking with a stick seemed to be supporting this. |
As discussed on gitter, I also think the backport is a good idea. |
Fixes #9945