[topfmt] Set formatter + flush fix #12358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejgallego
force-pushed
the
redirect_printing_params
branch
from
5de4798
to
770454c
Compare
ejgallego
added
kind: fix
JasonGross
approved these changes
May 18, 2020
doc/changelog/07-commands-and-options/12358-redirect_printing_params.rst
Outdated
Show resolved
Hide resolved
Yup to both |
ejgallego
force-pushed
the
redirect_printing_params
branch
2 times, most recently
from
a5badf2
to
cd9bb12
Compare
Closes coq#12351. We set the parameters of the redirect formatter to be same than the ones in stdout. I guess the original semantics was to ignore the parameters, so I'm unsure we want to do this. While we are a it, we include a fix on the formatter, which _must_ be flushed before closing its associated channel.
ejgallego
force-pushed
the
redirect_printing_params
branch
from
cd9bb12
to
fb0caf1
Compare
SkySkimmer
approved these changes
May 20, 2020
|
@JasonGross , the overlay again won't be backwards compatible, what should we do tho? Do you want to propagate the diff tweak hack? |
|
Sure, feel free to submit a PR that extends the diff hack, or else I can do it when I get a chance |
|
I'll be on holidays until Monday, so it is likely I don't get the chance to help with this soon. |
JasonGross
added a commit
to mit-plv/fiat-crypto
that referenced
this pull request
May 20, 2020
Compatibility with coq/coq#12358
|
Should be fixed by mit-plv/fiat-crypto@2b5c790 |
Zimmi48
added a commit
to Zimmi48/coq
that referenced
this pull request
May 22, 2020
Zimmi48
added a commit
to Zimmi48/coq
that referenced
this pull request
May 23, 2020
Zimmi48
added a commit
to Zimmi48/coq
that referenced
this pull request
May 23, 2020
Zimmi48
added a commit
to Zimmi48/coq
that referenced
this pull request
May 23, 2020
Zimmi48
added a commit
to Zimmi48/coq
that referenced
this pull request
May 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12351.
We set the parameters of the redirect formatter to be same than the
ones in stdout.
I guess the original semantics was to ignore the parameters, so I'm
unsure we want to do this.
While we are a it, we include a fix on the formatter, which must be
flushed before closing its associated channel.