Move serialization functions out of Stm #181
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fine with the idea, but I dislike Inl/Inr (in general, it's like monads, it irritates my skin) and here I guess an option type is just fine. I'll merge it this afternoon. |
|
Cool, thanks Enrico! Give me 10 minutes to push a fix for your comments. |
ejgallego
force-pushed
the
stm-remove-serialization
branch
from
e3e2926 to
0dd58bd
Compare
Serialization should be specific to each particular backend, so we let the Stm clients choose how the send the nodes. This should be quite safe to pull in. Test suite passes. Related to rocq-prover#180
ejgallego
force-pushed
the
stm-remove-serialization
branch
from
0dd58bd to
03f6c8b
Compare
|
Ok @gares , this is ready to merge now IMO. |
|
Integrated in #180 |
jfehrle
pushed a commit
to jfehrle/coq
that referenced
this pull request
Dec 19, 2022
181: Adapt to Coq's PR rocq-prover#9909 r=ppedrot a=maximedenes To be merged only once rocq-prover#9909 is. Co-authored-by: Maxime Dénès <maxime.denes@inria.fr>
proux01
pushed a commit
to proux01/rocq
that referenced
this pull request
Sep 10, 2024
Add Ali Caglayan to the maintainers team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialization should be specific to each particular backend, so we let
the Stm clients choose how the send the nodes.
This should be quite safe to pull in. Test suite passes.
Related to #180