Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coqdoc handling of empty logical path #19036

Merged
merged 1 commit into from
May 17, 2024

Conversation

SkySkimmer
Copy link
Contributor

Fix #19012

I didn't test beyond that coqdoc -Q /tmp "" doesn't crash.

Fix coq#19012

I didn't test beyond that `coqdoc -Q /tmp ""` doesn't crash.
@SkySkimmer SkySkimmer requested a review from a team as a code owner May 16, 2024 17:00
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label May 16, 2024
@proux01 proux01 added kind: fix This fixes a bug or incorrect documentation. part: coqdoc The coqdoc binary for building documentation. and removed needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. labels May 17, 2024
@proux01 proux01 self-assigned this May 17, 2024
@proux01 proux01 added this to the 8.20+rc1 milestone May 17, 2024
@proux01
Copy link
Contributor

proux01 commented May 17, 2024

@coqbot merge now

@coqbot-app coqbot-app bot merged commit 21601f5 into coq:master May 17, 2024
6 checks passed
@SkySkimmer SkySkimmer deleted the coqdoc-empty-logpath branch May 21, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: fix This fixes a bug or incorrect documentation. part: coqdoc The coqdoc binary for building documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coqdoc -Q foo "" fails with invalid_argument
2 participants