Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[warnings] Please fix OCaml warnings #107

Closed
ejgallego opened this issue Feb 19, 2019 · 0 comments · Fixed by #108
Closed

[warnings] Please fix OCaml warnings #107

ejgallego opened this issue Feb 19, 2019 · 0 comments · Fixed by #108

Comments

@ejgallego
Copy link
Member

Dear devs,

in Coq we are considering requiring plugins in the CI to use the same set of compiler flags for warnings than the main Coq tree (c.f. coq/coq#9605 ), in particular, this means that the plugins should now compile warning-free, except for deprecation notices.

Note that some of the raised warnings are really fatal, [like missing match cases].

Please, try to fix OCaml warnings present in your codebase, thanks!
@ejgallego ejgallego mentioned this issue Feb 19, 2019
Merged
ejgallego added a commit to ejgallego/ltac2 that referenced this issue Feb 20, 2019
@ejgallego
[coq] Fix OCaml warnings.
69af5f4 
In anticipation to coq/coq#9605 , we fix all
OCaml warnings.

Fixes coq#107
@ejgallego ejgallego mentioned this issue Feb 20, 2019
Merged
jfehrle pushed a commit to jfehrle/coq that referenced this issue May 7, 2019
@ejgallego
[coq] Fix OCaml warnings.
7c976ed 
In anticipation to coq#9605 , we fix all
OCaml warnings.

Fixes coq/ltac2#107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[coq] Fix OCaml warnings. ejgallego/ltac2
1 participant
@ejgallego