patch coq-stdpp.1.8.0 for Coq 8.18, dropping 8.12 support #2747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah this seems fine, thanks! (Also raising the minimum version to 8.13 and always applying the patch seems fine.) |
|
OK, an unconditional patch is probably easier to maintain in the longer term. So since dropping 8.12 support is fine, let's go with that. |
palmskog
force-pushed
the
stdpp-1.8.0-8.18
branch
from
ce978f3
to
b3fd668
Compare
palmskog
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coq-stdpp.1.8.0 breaks on Coq 8.18.0 due to changes in Stdlib related to
currydefinitions. Here is a conditional patch to fix this while preserving compatibility with earlier Coq.This is useful to let stdpp users migrate to 8.18.0 before stdpp 1.9.0 comes out, so hopefully is fine with you @RalfJung?