Skip to content

Conversation

andres-erbsen
Copy link
Collaborator

This change was discussed extensively at rocq-prover/rocq#19747 with no remaining objections.

  • Added changelog.
  • Updated test suite

@andres-erbsen
Copy link
Collaborator Author

The CI errors look unrelated to me, but I'd appreciate another pair of eyes that.

jasmin:

[deprecated-coq-env-var,deprecated-since-9.0,deprecated,default]File "./itrees/xrutt.v", line 26, characters 5-21:
Error: Cannot find a physical path bound to logical path
Structures.Monad with prefix ExtLib.

elpi:

warning: error: unable to download 'https://github.com/LPCIC/coq-elpi/archive/master.tar.gz': HTTP error 500

metacoq-utils:

sed: can't read ./template-coq/gen-src/to-lower.sh: No such file or directory

@andres-erbsen
Copy link
Collaborator Author

@vbgl: Can you advise whether the CI failure for Jasmin indicates a problem with this PR? Thanks!
@mattam82: Can you advise whether the CI failure for Metarocq indicates a problem with this PR? Thanks!

@vbgl
Copy link
Contributor

vbgl commented Apr 29, 2025

Regarding the Jasmin failure, this is probably a bug in the CI infrastructure (undeclared dependency) so unrelated to this PR.

@andres-erbsen andres-erbsen requested a review from proux01 May 4, 2025 02:41
@mattam82
Copy link
Member

mattam82 commented May 6, 2025

I think the CI failure on metarocq indicates that we must update the nix derivation in the stdlib CI

@andres-erbsen
Copy link
Collaborator Author

Thank you! I intend to merge after I put changelog in the right place, perhaps tomorrow.

@andres-erbsen andres-erbsen merged commit 9652597 into rocq-prover:master May 8, 2025
231 of 236 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants