-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix VITS upsampling asserts #1550
Conversation
d7e079d
to
ecff669
Compare
I don't even see an assert fix in this PR? Do I miss something ? |
It fixes the upsampling asserts during the training. Without this, we can't train the model, because depending on the length of the audio the spectrogram length multiplied by the upsampling factor is not equal to the mel-spectrogram length. So I removed some frames of the audio like @WeberJulian did for the bandwidth extension model We have two alternatives to the training works:
|
I don't see an assert removed in the changes. |
Because I have chosen to apply the changes in this PR. This PR fixes the asserts errors during the training keeping the asserts. |
I don't understand, sorry. Where are the asserts? What assert did you change? Do you mean |
These asserts 1 and 2 in some cases (depending on the audio length) break the upsampling training. So to fix this bug I submitted this PR. |
Can you link to your exact changes in the code which fix those asserts? I don't understand how you fix those lines without touching those lines |
a66f13b
to
b51e54c
Compare
My bad I accidentally included the reinit encoder/duration predictor. Now I kept on this PR just the code that solves the asserts and added the reinit encoder/duration predictor in the PR #1562.
These asserts are about the audio/spectrogram length, so if we guarantee that the audio/spectrogram is divisible by the upsampling factor, the problem is solved. |
Fix style
* Add reinit encoder and duration predictor option * Add .data to prevent any overlooked autograd hook
d2f8027
to
175ca06
Compare
Fix upsampling VITS asserts that was broken.