Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audio length sampler balancer #1561

Merged
merged 2 commits into from
May 12, 2022
Merged

Add audio length sampler balancer #1561

merged 2 commits into from
May 12, 2022

Conversation

Edresson
Copy link
Contributor

@Edresson Edresson commented May 6, 2022

No description provided.

@erogol
Copy link
Member

erogol commented May 7, 2022

It'd need testing as well.

@Edresson Edresson force-pushed the fix-upsampling-asserts branch 2 times, most recently from a66f13b to b51e54c Compare May 7, 2022 17:13
@Edresson
Copy link
Contributor Author

Edresson commented May 7, 2022

It'd need testing as well.

Indeed, done.

@Edresson Edresson requested a review from erogol May 7, 2022 18:58
@erogol
Copy link
Member

erogol commented May 9, 2022

All good, but we just need to see its effectiveness in training.

@Edresson
Copy link
Contributor Author

Edresson commented May 9, 2022

All good, but we just need to see its effectiveness in training.

We are already using this in our trainings. So everything is good.

@erogol erogol changed the base branch from fix-upsampling-asserts to dev May 12, 2022 11:06
@erogol
Copy link
Member

erogol commented May 12, 2022

Is it okay merging it to dev?

@Edresson
Copy link
Contributor Author

Is it okay merging it to dev?

I rebased, now we can merge it :)

@erogol erogol merged commit c6008e5 into dev May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants