-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes and add support for multiples speaker references on XTTS inference #3149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edresson
force-pushed
the
fixup_xtts_v2
branch
from
November 6, 2023 17:21
aa0bbce
to
f06fddc
Compare
Edresson
commented
Nov 6, 2023
erogol
requested changes
Nov 6, 2023
@Edresson can you implement a test case for it? |
XTTS tests are heavy, so I changed xtts v1 streaming test to use multiple references and xtts v1 non-streaming I kept it using only one. XTTS v2 non-streaming uses multiple references and streaming uses a single reference. Note that the code is the same so all is covered. |
akx
reviewed
Nov 6, 2023
Edresson
changed the title
Add support for multiples speaker references on XTTS inference
Add support for multiples speaker references on XTTS inference and bug fixes
Nov 6, 2023
Edresson
changed the title
Add support for multiples speaker references on XTTS inference and bug fixes
Bug fixes and add support for multiples speaker references on XTTS inference
Nov 6, 2023
This was referenced Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.