For fairseq fix missing dataset, model var initialization #3471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple fix for fairseq issue.
Issue : When loading the model we get
Both
dataset
andmodel
are not defined/set in the branch that handlesfairseq
.Addition : Initialized the variables in the branch.
Maybe its better to conform with the rest of the code, where the variables are unpacked from the str.split. What do you think?
PS - could not do a successful
make install
and subsequent test, but successfully tested on applying the changes and testing with this code