Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant calls to keys() method of name_to_id #3487

Closed
wants to merge 1 commit into from
Closed

Remove redundant calls to keys() method of name_to_id #3487

wants to merge 1 commit into from

Conversation

imkasen
Copy link

@imkasen imkasen commented Jan 3, 2024

Fix the problem that I mentioned in #3434 (comment).

name_to_id() in class SpeakerManager already returns dict_keys type, but keys() method is called again on name_to_id in speaker_names(), which results in the error AttributeError: 'dict_keys' object has no attribute 'keys'

@CLAassistant
Copy link

CLAassistant commented Jan 3, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

stale bot commented Feb 3, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You might also look our discussion channels.

@stale stale bot added the wontfix This will not be worked on but feel free to help. label Feb 3, 2024
@stale stale bot closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on but feel free to help.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants