Allow file-like objects when saving and loading #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@agrinh Sorry for the delay. I missed the PR among a ton of Github notifications. I guess you reverted the changes you made in the first commit? |
agrinh
force-pushed
the
allow-file-objects
branch
from
a370870
to
c1f5c96
Compare
|
@erogol No worries 🙂 Sorry I'm confused, what changes do you mean I reverted? I don't think I've reverted anything. Seems like the check was unhappy about some lint, so I rebased against master. Hope that this works. |
|
late merge but good merge :) |
|
I needed to revert it as it fails with p3.6 |
|
@erogol Is there a traceback somewhere? |
|
@agrinh alas no but |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to save the configs to arbitrary locations through file-like objects. Would e.g. simplify coqui-ai/TTS#683 without adding an
fsspecdependency to this library.