lang: add check that declared id == program id #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wasnt quite sure which category to put the error under. used |
lang/src/error.rs
Outdated
| // Miscellaneous | ||
| /// 50 - The declared program id does not match actual program id | ||
| #[msg("The declared program id does not match the actual program id")] | ||
| DeclaredProgramIdMismatch = 50, |
There was a problem hiding this comment.
Will this collide with solana_program error codes? Probably not?
There was a problem hiding this comment.
probably not but no reason to take that risk. we can move the misc errors to 4500
tests/declare-id/package-lock.json
Outdated
| @@ -0,0 +1,16 @@ | |||
| { | |||
tests/declare-id/yarn.lock
Outdated
| @@ -0,0 +1,4 @@ | |||
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | |||
|
implemented review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.